Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR for build tool #27

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Add ADR for build tool #27

merged 4 commits into from
Jan 18, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jan 16, 2024

resolves dbt-labs/dbt-adapters#3

Description

This is just the adr to make it more clear. #21 will follow with more complete hatch implementation.

Checklist

@emmyoop emmyoop changed the title add adr Add ADR for build tool Jan 16, 2024
@emmyoop emmyoop requested review from MichelleArk and a team January 16, 2024 14:43
Copy link

@martynydbt martynydbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having only one maintainer is pretty high risk.
How much effort does it take to switch between tools should it become abandonware?

@emmyoop
Copy link
Member Author

emmyoop commented Jan 16, 2024

@martynydbt while it only has 1 maintainer it is actually part of the Python Packaging Authority (PyPA) and lives in the PyPA org in GitHub. PyPA is a working group that maintains a core set of software projects used in Python packaging. it also has had 69 contributors over its lifetime. I can add this color to the doc.

@emmyoop emmyoop requested a review from martynydbt January 18, 2024 18:40
@emmyoop emmyoop merged commit 069043b into main Jan 18, 2024
6 checks passed
@emmyoop emmyoop deleted the er/bild-tooling-adr branch January 18, 2024 18:47
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spike] settle on build tooling
4 participants